Don't mind the ones in the "public" folder paths, it's just a Windows 10/11 thing. They're supposed to be empty, and as long as those are empty, they're fine, nothing to worry about.

Likely, your files were moved to the new location (Desktop?) when you removed OneDrive. I'm guessing the "Desktop" location is the one that the game now reads from, since it made new files there.

You should be able to copy over the old files (as in, delete the folders inside "The sims 2 ultimate collection" from the working path, copy/paste in the ones from the not-working path, and try running the game again. DO NOT OVERWRITE FOLDERS!!! Or you'll have even more issues going on).

(Make sure to do a backup of your old game first, just in case).

So do i like copy the files from my normal documents Sims 2 ultimate collection folder to my new sims 2 desktop folder or...

(Edited my post above a bit)

You'll need to figure out which path the game is reading from. Then you copy your old game over there (again - delete, then copy/paste files, don't overwrite).